{"id":"GHSA-v9v2-98xq-627c","summary":"pREST _groupby function-expression SQL injection (incomplete fix of CVE-2025-58450)","details":"What the fix did and the gap\n----------------------------\nThe v2.3.0 fix (commit e88dabb) routed the _select field through a strict new gate, sanitizeSelectField (postgres.go:947/1003/2097). The sibling _groupby path was left on the far weaker isSafeSQLExpression. adapters/postgres/postgres.go, GroupByClause (line 1946): a _groupby field that contains balanced parens takes the raw-SQL-expression branch (around lines 1999-2006), gated only by isSafeSQLExpression (line 2001, defined at 2043). That gate validates only the OUTERMOST function name against a 13-entry allowlist and uses a character allowlist that permits spaces, single quotes and parens. It blocks ;, --, /* , unbalanced parens and an outer pg_ prefix, but NOT a trailing UNION SELECT ..., a nested (SELECT ...) subquery, or an inner pg_ function. sanitizeSelectField (the CVE fix) rejects exactly those.\n\nInput and attacker\n-------------------\nGET /{database}/{schema}/{table}?_select=id&_groupby=upper((SELECT+1))+UNION+SELECT+current_user. Sink trace: controllers/crud.go:131 calls GroupByClause unconditionally, concatenates it into sqlSelect (crud.go:133), executed at crud.go:176 with only the WHERE values parameterized. Reached after only a table read-permission check, passable unauthenticated in the default config (the same pipeline and attacker model as the anchor).\n\nVerification level\n------------------\nEXECUTED with negative controls (agent-run go test ./adapters/postgres/, PASS): isSafeSQLExpression wrongly accepts four payloads and GroupByClause emits them raw (e.g. GROUP BY upper((SELECT 1)) UNION SELECT current_user, and GROUP BY abs((SELECT 1 FROM pg_sleep(3)))); negative controls with ; and -- are rejected; and sanitizeSelectField (the CVE fix) rejects the exact UNION payload the sibling gate accepts. I independently re-confirmed at HEAD that _groupby is gated by isSafeSQLExpression (postgres.go:2001) while _select uses sanitizeSelectField (postgres.go:947). NOT verified: end-to-end UNION exfiltration against a live Postgres (needs column/type alignment, Postgres-gated). The pg_sleep DoS primitive is unconditional and needs no alignment; char-by-char blind extraction is constrained (commas are pre-split, and =/\u003c/\u003e are blocked).\n\nSuggested fix\n-------------\nRoute _groupby through the same strict gate as _select (sanitizeSelectField-style: reject nested subqueries, UNION, inner pg_ functions, and anything past a single allowlisted function call), or parameterize/whitelist the group-by columns.\n\nAlso checked and SOUND\n----------------------\nThe other builders (WhereByRequest, OrderByRequest, JoinByRequest, CountByRequest, the jsonb/tsquery paths, -\u003e\u003ehaving, ident.IsValid) are sound; only the _groupby non-having function branch is the weak sibling.\n\nAdvisory-source note\n--------------------\nFive-source enumeration: CVE-2025-58450 (GHSA-p46v-f2x8-qp98, \"Systemic SQL Injection\", GO-2025-3941) and the newer GHSA-qvx3-q8vx-9q3c (which covers _select, fixed v2.3.0). Neither mentions _groupby / GROUP BY. The systemic advisory's own \"nested queries can be performed\" note supports the incomplete-fix framing. Not contested.\n\nDedup\n-----\nDedup gate clean: no prest/prest blocking verdict in COVERED-INDEX, DISCLOSURE-INDEX or SCOUT-EXCLUDE.\n\nTooling\n-------\nAI assistance wsa used while investigating. The injection is executed-verified with negative controls (isSafeSQLExpression accepts four UNION/subquery/pg_sleep payloads that GroupByClause emits raw, while ;/-- are rejected and the _select gate rejects the same UNION payload), and I confirmed at HEAD that _groupby uses the weak isSafeSQLExpression while _select was hardened with sanitizeSelectField.","aliases":["CVE-2026-104129"],"modified":"2026-11-20T15:00:07.782525749Z","published":"2026-11-20T14:41:42Z","database_specific":{"github_reviewed_at":"2026-11-20T14:41:42Z","nvd_published_at":"2026-11-19T19:17:17Z","cwe_ids":["CWE-89"],"severity":"HIGH","github_reviewed":true},"references":[{"type":"WEB","url":"https://github.com/prest/prest/security/advisories/GHSA-v9v2-98xq-627c"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2026-104129"},{"type":"WEB","url":"https://github.com/prest/prest/pull/1014"},{"type":"WEB","url":"https://github.com/prest/prest/commit/084348fa82701b098492fc520557ff290b7691e2"},{"type":"WEB","url":"https://github.com/prest/prest/commit/73e4b2aea81e2dbd33942efcb1a313fe3b151a41"},{"type":"PACKAGE","url":"https://github.com/prest/prest"},{"type":"WEB","url":"https://github.com/prest/prest/releases/tag/v2.4.0"}],"affected":[{"package":{"name":"github.com/prest/prest","ecosystem":"Go","purl":"pkg:golang/github.com/prest/prest"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"1.5.5"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-v9v2-98xq-627c/GHSA-v9v2-98xq-627c.json"}},{"package":{"name":"github.com/prest/prest/v2","ecosystem":"Go","purl":"pkg:golang/github.com/prest/prest/v2"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"2.4.0"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-v9v2-98xq-627c/GHSA-v9v2-98xq-627c.json","last_known_affected_version_range":"\u003c= 2.3.0"}}],"schema_version":"1.9.2","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:N"}]}