{"id":"GHSA-rm8w-w798-g545","summary":"compose-lint: Incomplete fix for GHSA-jf3h-8jvx-vcrg: a run stopped at the finding limit quotes a secret from a CI-generated `.env`","details":"### Impact\n\nThis is an incomplete fix for GHSA-jf3h-8jvx-vcrg. 0.32.0 made findings quote the `${NAME}` a sibling `.env` filled in, instead of its value. The same release added a stop at 20,000 findings per document, and that stop is checked before the quoting step. A run that hits it reports the findings graded so far with the resolved values still in them, in text, JSON and SARIF output. That happens with or without `--allow-partial-coverage`.\n\nThe attack is the one GHSA-jf3h-8jvx-vcrg describes. In a CI workflow that writes secrets into the `.env` beside the Compose file, a pull request changes a line to `image: \"${DB_PASSWORD}\"`. It also pushes the document past 20,000 findings, which a few hundred lines can do, because an aliased list is graded once for each service that uses it. The secret's value is quoted in a finding that reaches the job log, the JSON output and the SARIF uploaded to Code Scanning. GitHub masks registered secrets in the job log, but not in uploaded JSON or SARIF artifacts or in Code Scanning alert text. The run exits 2, or 0 with `--allow-partial-coverage`, after the output has been written.\n\nThe preconditions are the same as for GHSA-jf3h-8jvx-vcrg. The workflow writes secrets into the `.env` beside the Compose file *and* runs on pull requests from authors who should not see them, such as a `pull_request_target` workflow that lints the pull request's files. Pull requests from forks normally run without secrets, so the common setup is not exposed. The inflated document is visible in the pull request, but the workflow runs before anyone reviews it.\n\nFound during an internal pre-1.0 security review.\n\n**Python package.** `compose-lint` 0.32.0. Earlier releases have no finding limit, and their quoting gap is GHSA-jf3h-8jvx-vcrg itself.\n\n**GitHub Action.** Action tag v0.32.0 is affected. Tags before v0.22.0 install the newest release unless `version:` is set, so they currently install 0.32.0.\n\n**pre-commit hook.** `rev: v0.32.0`.\n\n**Docker image.** `composelint/compose-lint:0.32.0`, `:0.32` and `latest` are affected when the `.env` is mounted with the project.\n\n### Patches\n\nNo fixed release yet.\n\n### Workarounds\n\n- Run with `--no-env`, which skips the sibling `.env`.\n- Don't write secrets into the `.env` beside the Compose file in a job that lints untrusted pull requests.\n\n### Reproduction\n\n```\nproject/.env          DB_PASSWORD=example-secret      (written by CI, not committed)\nproject/compose.yml   x-p: &p [ ...200 port mappings... ]\n                      services: one service with image: \"${DB_PASSWORD}\" and ports: *p,\n                                plus about 100 more services with ports: *p\n```\n\n`compose-lint --format sarif compose.yml` exits 2 with \"grading stopped at 20000 findings\", and the reported findings contain `example-secret`. The same file with fewer services stays under the limit and quotes `${DB_PASSWORD}`. Checked against the 0.32.0 wheel from PyPI, using a synthetic value.","aliases":["CVE-2026-123796"],"modified":"2026-11-10T16:15:05.748535145Z","published":"2026-11-10T15:57:22Z","database_specific":{"github_reviewed_at":"2026-11-10T15:57:22Z","nvd_published_at":"2026-11-09T18:17:26Z","cwe_ids":["CWE-200","CWE-532"],"severity":"LOW","github_reviewed":true},"references":[{"type":"WEB","url":"https://github.com/tmatens/compose-lint/security/advisories/GHSA-rm8w-w798-g545"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2026-123796"},{"type":"WEB","url":"https://github.com/tmatens/compose-lint/pull/978"},{"type":"WEB","url":"https://github.com/tmatens/compose-lint/commit/31ec460399e06e98aa0d1cc578368a1960a8a0b3"},{"type":"PACKAGE","url":"https://github.com/tmatens/compose-lint"},{"type":"WEB","url":"https://github.com/tmatens/compose-lint/releases/tag/v0.33.0"}],"affected":[{"package":{"name":"compose-lint","ecosystem":"PyPI","purl":"pkg:pypi/compose-lint"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0.32.0"},{"fixed":"0.33.0"}]}],"versions":["0.32.0"],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-rm8w-w798-g545/GHSA-rm8w-w798-g545.json"}},{"package":{"name":"tmatens/compose-lint","ecosystem":"GitHub Actions"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0.32.0"},{"fixed":"0.33.0"}]},{"type":"GIT","repo":"https://github.com/tmatens/compose-lint","events":[{"introduced":"2d42617e4c6416f797bbfc6a057950131fa02df3"},{"fixed":"691e08bd1881ada886e3f556d0793079e8114451"}]}],"versions":["0.32.0","v0.32.0"],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-rm8w-w798-g545/GHSA-rm8w-w798-g545.json"}}],"schema_version":"1.9.2","severity":[{"type":"CVSS_V4","score":"CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:L/VI:N/VA:N/SC:N/SI:N/SA:N"}]}