{"id":"GHSA-hghq-53p7-c582","summary":"go-guerrilla crashes on a bare XCLIENT command (7-byte slice off-by-one panic)","details":"The defect\n----------\nConfirmed at HEAD. server.go: cmdXCLIENT = []byte(\"XCLIENT\") is 7 bytes (line 78), so the dispatch match cmdXCLIENT.match(cmd) only guarantees len(input) \u003e= 7. The handler then slices input[8:] (line 586):\n\n    case sc.XClientOn && cmdXCLIENT.match(cmd):\n        if toks := bytes.Split(input[8:], []byte{' '}); len(toks) \u003e 0 {   // line 586\n\nA client sending the bare command XCLIENT (exactly 7 bytes) hits input[8:7] and panics runtime error: slice bounds out of range [8:7]. handleClient runs in the per-connection goroutine (server.go:391) which has no recover(); the only recover() calls are in the backend mail-processing workers (a different goroutine never reached during command parsing), so the unrecovered panic crashes the whole SMTP daemon.\n\nInput and attacker\n-------------------\nConnect to the SMTP port, then send XCLIENT\\r\\n (a bare LF also works; no HELO needed). Precondition: xclient_on: true (off by default, but a documented nginx-fronted deployment; go-guerrilla does not restrict who may send XCLIENT). Attacker model: any unauthenticated client on the SMTP port.\n\nVerification level\n------------------\nEXECUTED with a negative control (agent-run, driving the real server.handleClient with XClientOn=true over the suite's mock net.Conn). The bare XCLIENT panics with the exact OOB; the negative control XCLIENT with a trailing space (8 bytes) does not panic and returns 250. The upstream TestXClient tests XCLIENT ADDR=... and XCLIENT c but never the bare 7-byte form (the missing regression case). I independently re-confirmed at HEAD that cmdXCLIENT is 7 bytes (server.go:78), that the handler slices input[8:] (server.go:586), and that handleClient (server.go:391) has no recover. NOT verified: did not stand up a standalone daemon on a real socket to observe OS-level process exit (used the mock net.Conn plus the traced absence of recover; crash-to-exit is standard Go runtime behavior).\n\nSuggested fix\n-------------\nGuard the slice against the exact-verb-length case: require len(input) \u003e len(cmdXCLIENT)+1 (or slice at the verb length and trim) before input[8:]. A recover in the per-connection handleClient loop would also contain any residual command-parse panic to the single connection.\n\nAlso checked and SOUND\n----------------------\nThe rfc5321 recursive-descent parser (MAIL/RCPT/HELO/EHLO/address) is bounds-safe (next()/peek() return 0 at EOF), and the line/size/recipient caps are enforced. XCLIENT is the only off-by-one; every other command arm slices exactly at its verb length.\n\nAdvisory-source note\n--------------------\nFive-source enumeration (repo advisories, OSV, NVD, the global GitHub DB, no vendor CNA) shows the PROXY-header IP-spoof bug (CVE-2025-31135, fixed v1.6.7) is the only published advisory; this XCLIENT panic is undisclosed and not contested.\n\nDedup\n-----\nDedup gate clean: no phires/go-guerrilla blocking verdict in COVERED-INDEX, DISCLOSURE-INDEX or SCOUT-EXCLUDE.\n\nTooling\n-------\nAI assistance was used while investigating. The panic is executed-verified with a negative control (a bare XCLIENT crashes the real handleClient while XCLIENT with a trailing space returns 250), and the reporter confirmed at HEAD that cmdXCLIENT is 7 bytes while the handler slices input[8:] on a per-connection goroutine with no recover.","aliases":["CVE-2026-115578"],"modified":"2026-11-20T15:00:07.726946553Z","published":"2026-11-20T14:42:18Z","database_specific":{"severity":"HIGH","github_reviewed":true,"github_reviewed_at":"2026-11-20T14:42:18Z","nvd_published_at":"2026-11-19T20:17:19Z","cwe_ids":["CWE-129","CWE-193","CWE-248"]},"references":[{"type":"WEB","url":"https://github.com/phires/go-guerrilla/security/advisories/GHSA-hghq-53p7-c582"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2026-115578"},{"type":"WEB","url":"https://github.com/phires/go-guerrilla/commit/b6deed97ff70f52bf34c386d33967694e7330d33"},{"type":"WEB","url":"https://github.com/phires/go-guerrilla/commit/f0d0f2c40dcacf212e3a6a055ae67f7b412affc4"},{"type":"PACKAGE","url":"https://github.com/phires/go-guerrilla"},{"type":"WEB","url":"https://github.com/phires/go-guerrilla/releases/tag/v1.6.7-1"}],"affected":[{"package":{"name":"github.com/phires/go-guerrilla","ecosystem":"Go","purl":"pkg:golang/github.com/phires/go-guerrilla"},"versions":["1.6.7"],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-hghq-53p7-c582/GHSA-hghq-53p7-c582.json"}},{"package":{"name":"github.com/phires/go-guerrilla","ecosystem":"Go","purl":"pkg:golang/github.com/phires/go-guerrilla"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"1.6.7-1"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-hghq-53p7-c582/GHSA-hghq-53p7-c582.json"}}],"schema_version":"1.9.2","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"}]}