{"id":"GHSA-ghmh-jhmj-wcmf","summary":"nebula-mesh's stores enrollment tokens unhashed in SQLite","details":"`internal/store/sqlite.go:1177,1192,1221,1245` — the `enrollment_tokens.token` column holds the raw UUID token. `ConsumeToken` does `WHERE token = ?` against the raw string. Compare with `operator_api_keys.key_hash`, which is SHA-256 hex (constructed in `internal/api/middleware.go:51-53`).\n\n## Affected\nAll released versions up to v0.3.0.\n\n## Threat model\nRead access to `nebula-mgmt.db`: backup, snapshot, file-system access, future SQL-injection sink. The principle of defense-in-depth: API keys are hashed at rest; enrollment tokens — which grant the same lifecycle authority over a host's identity — are not.\n\nAn attacker who reads the DB before a legitimate agent enrolls can consume the single-use token first, mint a cert against their own keypair, and take the agent's intended Nebula identity.\n\n## Suggested fix\n1. Schema migration: rename `enrollment_tokens.token` → `token_hash` (or add the new column and drop the old after backfill of pending rows).\n2. Store SHA-256 of token on create:\n   ```go\n   sum := sha256.Sum256([]byte(token))\n   row.TokenHash = hex.EncodeToString(sum[:])\n   ```\n3. `ConsumeToken` accepts the raw token, hashes once, looks up by hash, atomically marks consumed.\n\nSide bonus: take this opportunity to switch the token format from `uuid.New().String()` (122 bits) to `hex.EncodeToString(crypto/rand 32 bytes)` (256 bits), matching the project's session-token and API-key conventions. UUIDs are recognisable in logs and crash dumps; opaque hex blends in.\n\nTOTP recovery codes appear to already be SHA-256 hashed at rest (`internal/web/totp.go:74-78`) — confirming that pattern is intentional elsewhere, just missed here.","aliases":["GO-2026-5399"],"modified":"2026-06-25T23:11:47.620382880Z","published":"2026-06-22T22:57:27Z","database_specific":{"github_reviewed":true,"github_reviewed_at":"2026-06-22T22:57:27Z","nvd_published_at":null,"cwe_ids":["CWE-312"],"severity":"MODERATE"},"references":[{"type":"WEB","url":"https://github.com/juev/nebula-mesh/security/advisories/GHSA-ghmh-jhmj-wcmf"},{"type":"PACKAGE","url":"https://github.com/juev/nebula-mesh"}],"affected":[{"package":{"name":"github.com/juev/nebula-mesh","ecosystem":"Go","purl":"pkg:golang/github.com/juev/nebula-mesh"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"0.3.2"}]}],"database_specific":{"last_known_affected_version_range":"\u003c= 0.3.1","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/06/GHSA-ghmh-jhmj-wcmf/GHSA-ghmh-jhmj-wcmf.json"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V4","score":"CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:L/VI:H/VA:N/SC:N/SI:N/SA:N/E:U"}]}