{"id":"GHSA-fpgf-pjjv-2qgm","summary":"matrix-android-sdk2 vulnerable to Olm/Megolm protocol confusion","details":"### Impact\nAn attacker cooperating with a malicious homeserver can construct messages that legitimately appear to have come from another person, without any indication such as a grey shield. \n\nAdditionally, a sophisticated attacker cooperating with a malicious homeserver could employ this vulnerability to perform a targeted attack in order to send fake to-device messages appearing to originate from another user. This can allow, for example, to inject the key backup secret during a self-verification, to make a targeted device start using a malicious key backup spoofed by the homeserver. matrix-android-sdk2 would then additionally sign such a key backup with its device key, spilling trust over to other devices trusting the matrix-android-sdk2 device.\n\nThese attacks are possible due to a protocol confusion vulnerability that accepts to-device messages encrypted with Megolm instead of Olm.\n\n### Patches\n\nmatrix-android-sdk2 has been modified to only accept Olm-encrypted to-device messages and to stop signing backups on a successful decryption.\n\nOut of caution, several other checks have been audited or added:\n- Cleartext `m.room_key`, `m.forwarded_room_key` and `m.secret.send` to_device messages are discarded.\n- Secrets received from untrusted devices are discarded.\n- Key backups are only usable if they have a valid signature from a trusted device (no more local trust, or trust-on-decrypt).\n- The origin of a to-device message should only be determined by observing the Olm session which managed to decrypt the message, and not by using claimed sender_key, user_id, or any other fields controllable by the homeserver.\n\n\n### Workarounds\n\nAs this attack requires coordination between a malicious home server and an attacker, if you trust your home server no particular workaround is needed.  Notice that the backup spoofing attack is a particularly sophisticated targeted attack.\n\nWe are not aware of this attack being used in the wild, though specifying a false positive-free way of noticing malicious key backups key is challenging.\n\nAs an abundance of caution, to avoid malicious backup attacks, you should not verify your new logins using emoji/QR verifications methods until patched. Prefer using verify with passphrase.\n\n\n### References\nBlog post: https://matrix.org/blog/2022/09/28/upgrade-now-to-address-encryption-vulns-in-matrix-sdks-and-clients\n\n### For more information\nIf you have any questions or comments about this advisory, e-mail us at [security@matrix.org](mailto:security@matrix.org).\n","aliases":["CVE-2022-39248"],"modified":"2023-11-08T04:10:16.510187Z","published":"2022-09-30T04:37:39Z","database_specific":{"severity":"HIGH","github_reviewed":true,"github_reviewed_at":"2022-09-30T04:37:39Z","nvd_published_at":"2022-09-28T20:15:00Z","cwe_ids":["CWE-287","CWE-322"]},"references":[{"type":"WEB","url":"https://github.com/matrix-org/matrix-android-sdk2/security/advisories/GHSA-fpgf-pjjv-2qgm"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2022-39248"},{"type":"WEB","url":"https://github.com/matrix-org/matrix-android-sdk2/commit/77df720a238d17308deab83ecaa37f7a4740a17e"},{"type":"PACKAGE","url":"https://github.com/matrix-org/matrix-android-sdk2"},{"type":"WEB","url":"https://github.com/matrix-org/matrix-android-sdk2/releases/tag/v1.5.1"},{"type":"WEB","url":"https://matrix.org/blog/2022/09/28/upgrade-now-to-address-encryption-vulns-in-matrix-sdks-and-clients"}],"affected":[{"package":{"name":"org.matrix.android:matrix-android-sdk2","ecosystem":"Maven","purl":"pkg:maven/org.matrix.android/matrix-android-sdk2"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"},{"fixed":"1.5.1"}]}],"versions":["0.0.2","1.2.1","1.2.2","1.3.0","1.3.10","1.3.13","1.3.14","1.3.18","1.3.2","1.3.4","1.3.7","1.3.8","1.3.9","1.4.11","1.4.13","1.4.14","1.4.16","1.4.2","1.4.25","1.4.27","1.4.32","1.4.34","1.4.36","1.4.4"],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/09/GHSA-fpgf-pjjv-2qgm/GHSA-fpgf-pjjv-2qgm.json","last_known_affected_version_range":"\u003c= 1.4.36"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:N/I:H/A:N"}]}