{"id":"GHSA-f598-mfpv-gmfx","summary":"Sequelize - Default support for “raw attributes” when using parentheses","details":"### Impact\n\nSequelize 6.28.2 and prior has a dangerous feature where using parentheses in the attribute option would make Sequelize use the string as-is in the SQL\n\n```ts\nUser.findAll({\n  attributes: [\n    ['count(id)', 'count']\n  ]\n});\n```\n\nProduced\n\n```sql\nSELECT count(id) AS \"count\" FROM \"users\"\n```\n\n### Patches\n\nThis feature was deprecated in Sequelize 5, and using it prints a deprecation warning.\n\nThis issue has been patched in [`@sequelize/core@7.0.0.alpha-20`](https://github.com/sequelize/sequelize/pull/15374) and [`sequelize@6.29.0`](https://github.com/sequelize/sequelize/pull/15710). \n\nIn Sequelize 7, it now produces the following:\n\n```sql\nSELECT \"count(id)\" AS \"count\" FROM \"users\"\n```\n\nIn Sequelize 6, it throws an error explaining that we had to introduce a breaking change, and requires the user to explicitly opt-in to either the Sequelize 7 behavior (always escape) or the Sequelize 5 behavior (inline attributes that include `()` without escaping). See https://github.com/sequelize/sequelize/pull/15710 for more information.\n\n### Mitigations\n\nDo not use user-provided content to build your list or attributes. If you do, make sure that attribute in question actually exists on your model by checking that it exists in the `rawAttributes` property of your model first.\n\n---\n\nA discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15694\nCVE: CVE-2023-22578","aliases":["CVE-2023-22578"],"modified":"2023-11-08T04:11:36.970852Z","published":"2023-02-24T18:48:49Z","database_specific":{"cwe_ids":["CWE-790"],"severity":"CRITICAL","github_reviewed":true,"github_reviewed_at":"2023-02-24T18:48:49Z","nvd_published_at":null},"references":[{"type":"WEB","url":"https://github.com/sequelize/sequelize/security/advisories/GHSA-f598-mfpv-gmfx"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2023-22578"},{"type":"WEB","url":"https://github.com/sequelize/sequelize/pull/15710"},{"type":"WEB","url":"https://csirt.divd.nl/CVE-2023-22578"},{"type":"WEB","url":"https://csirt.divd.nl/DIVD-2022-00020"},{"type":"PACKAGE","url":"https://github.com/sequelize/sequelize"},{"type":"WEB","url":"https://github.com/sequelize/sequelize/discussions/15694"},{"type":"WEB","url":"https://github.com/sequelize/sequelize/releases/tag/v6.29.0"},{"type":"WEB","url":"https://github.com/sequelize/sequelize/releases/tag/v7.0.0-alpha.20"}],"affected":[{"package":{"name":"@sequelize/core","ecosystem":"npm","purl":"pkg:npm/%40sequelize/core"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"7.0.0-alpha.20"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/02/GHSA-f598-mfpv-gmfx/GHSA-f598-mfpv-gmfx.json"}},{"package":{"name":"sequelize","ecosystem":"npm","purl":"pkg:npm/sequelize"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"6.29.0"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/02/GHSA-f598-mfpv-gmfx/GHSA-f598-mfpv-gmfx.json"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H"}]}