{"id":"GHSA-cg26-4c6j-2x8h","summary":"netty-incubator-codec-ohttp: OHTTP codecs retain consumed outer cumulation buffers after completed exchanges","details":"## Summary:\n\nOHttpClientCodec and OHttpServerCodec retain the encrypted outer HttpContent in a handler-level cumulationBuffer. After a valid OHTTP exchange completes, the OHTTP request/response context is destroyed, but the outer cumulationBuffer is not released or reset. It remains referenced by the codec until a later inbound content frame replaces it or the handler is removed/channel is closed.\n\nThis can pin attacker-influenced pooled/direct buffer capacity on idle keep-alive channels. Across many long-lived idle connections, this can create availability pressure.\n\nAffected components:\n\n* codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpClientCodec.java\n* codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpServerCodec.java\n* codec-ohttp/src/main/java/io/netty/incubator/codec/ohttp/OHttpRequestResponseContext.java\n\n## Root cause:\n\nOHttpClientCodec retains inbound content into a handler-level cumulationBuffer. On LastHttpContent, it destroys only the OHttpRequestResponseContextHolder. The cumulationBuffer is released in handlerRemoved(), not immediately after successful exchange completion.\n\nOHttpServerCodec follows the same pattern: it retains inbound content into a handler-level cumulationBuffer, and on completed request/response it destroys the OHttpRequestResponseContext. The outer cumulationBuffer remains owned by the codec and is released only when the handler is removed.\n\nOHttpRequestResponseContext.parse() consumes bytes from the caller-provided outer cumulation buffer, but its destroy() path releases only the inner binary HTTP cumulation, not the codec-level outer cumulationBuffer.\n\n## PoC:\n\nA local test only:\n\n```\ncodec-ohttp/src/test/java/io/netty/incubator/codec/ohttp/OHttpCumulationBufferRetentionTest.java\n```\n\nThe test reuses existing OHTTP test helpers and BouncyCastle crypto provider to perform valid completed OHTTP exchanges over EmbeddedChannel pairs. It sends both a small and a large request/response exchange, confirms completion, then reflects the private cumulationBuffer field from both OHttpClientCodec and OHttpServerCodec.\n\nCommand:\n\n```\n./mvnw -pl codec-ohttp -Dtest=OHttpCumulationBufferRetentionTest -DfailIfNoTests=false test\n```\n\nObserved output:\n\n```\nsmall client after completion: refCnt=1 capacity=1064 readerIndex=1064 writerIndex=1064 readableBytes=0\nsmall server after completion: refCnt=1 capacity=1110 readerIndex=1110 writerIndex=1110 readableBytes=0\nlarge client after completion: refCnt=1 capacity=262144 readerIndex=131114 writerIndex=131114 readableBytes=0\nlarge server after completion: refCnt=1 capacity=262144 readerIndex=131160 writerIndex=131160 readableBytes=0\nsmall after close: clientOldRefCnt=0 serverOldRefCnt=0\nlarge after close: clientOldRefCnt=0 serverOldRefCnt=0\nTests run: 1, Failures: 0, Errors: 0, Skipped: 0\nBUILD SUCCESS\n```\n\nInterpretation:\n\nAfter completion, both the client and server cumulationBuffer objects have:\n\n* refCnt=1\n* readableBytes=0\n* large retained capacity for the large exchange\n* channel still open/active\n* OHTTP context completed/destroyed\n\nAfter channel close/handler removal, the previously retained buffers are released and their old refCnt values become 0.\n\n## Impact:\n\nA peer can complete a large valid OHTTP request/response and keep the connection open. The codec retains the high-water outer cumulation buffer for the lifetime of the idle keep-alive channel, or until a later inbound content frame replaces it. Across many idle keep-alive channels, this can pin pooled/direct memory and create availability pressure.\n\nThis is not unbounded growth per exchange on a single channel. The more precise impact is connection-lifetime retention of the current consumed high-water outer cumulation buffer.\n\n## Suggested fix:\n\nAfter successful LastHttpContent processing, release and reset the codec-level outer cumulationBuffer once parsing has consumed the complete message and no unread bytes remain.\n\nCare is needed not to release the buffer if unread bytes remain for pipelined data. A safe fix would release/reset the outer cumulationBuffer in the completed-exchange path only when the parse consumed the full outer body.\n\n## Test environment:\n\n* WSL Ubuntu\n* Java 11\n* Current main branch / 0.0.24.Final-SNAPSHOT\n* PoC test used BouncyCastleOHttpCryptoProvider and existing OHttpCodecsTest helpers\n\nAffected version testing:\n\nThe issue was reproduced on the following release tags:\n\n* netty-incubator-codec-parent-ohttp-0.0.20.Final\n* netty-incubator-codec-parent-ohttp-0.0.21.Final\n* netty-incubator-codec-parent-ohttp-0.0.22.Final\n* netty-incubator-codec-parent-ohttp-0.0.23.Final\n\nIt was also reproduced on main / 0.0.24.Final-SNAPSHOT.\n\nFor 0.0.20.Final through 0.0.23.Final, the PoC output consistently showed:\n\n* large client after completion: refCnt=1 capacity=262144 ... readableBytes=0\n* large server after completion: refCnt=1 capacity=262144 ... readableBytes=0\n* large after close: clientOldRefCnt=0 serverOldRefCnt=0\n* BUILD SUCCESS\n\nThis confirms that completed exchanges leave the consumed outer cumulation buffer retained until channel/handler close in these versions.","aliases":["CVE-2026-69133"],"modified":"2026-11-20T16:30:04.228142112Z","published":"2026-11-20T16:22:09Z","database_specific":{"nvd_published_at":"2026-11-19T22:18:08Z","cwe_ids":["CWE-772"],"severity":"MODERATE","github_reviewed":true,"github_reviewed_at":"2026-11-20T16:22:09Z"},"references":[{"type":"WEB","url":"https://github.com/netty/netty-incubator-codec-ohttp/security/advisories/GHSA-cg26-4c6j-2x8h"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2026-69133"},{"type":"WEB","url":"https://github.com/netty/netty-incubator-codec-ohttp/commit/a82cd85099c1a1fb78b73b068c77c8c902fc32ce"},{"type":"PACKAGE","url":"https://github.com/netty/netty-incubator-codec-ohttp"},{"type":"WEB","url":"https://github.com/netty/netty-incubator-codec-ohttp/releases/tag/netty-incubator-codec-parent-ohttp-0.0.27.Final"}],"affected":[{"package":{"name":"io.netty.incubator:netty-incubator-codec-ohttp","ecosystem":"Maven","purl":"pkg:maven/io.netty.incubator/netty-incubator-codec-ohttp"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0.0.20.Final"},{"fixed":"0.0.27.Final"}]}],"versions":["0.0.20.Final","0.0.21.Final","0.0.22.Final","0.0.23.Final","0.0.24.Final","0.0.25.Final","0.0.26.Final"],"database_specific":{"last_known_affected_version_range":"\u003c= 0.0.26.Final","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-cg26-4c6j-2x8h/GHSA-cg26-4c6j-2x8h.json"}}],"schema_version":"1.9.2","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"}]}