{"id":"GHSA-cfqx-f43m-vfh7","summary":"@saltcorn/server arbitrary file and directory listing when accessing build mobile app results","details":"### Summary\n\nA user with admin permission can read arbitrary file and directory names on the filesystem by calling the `admin/build-mobile-app/result?build_dir_name=` endpoint.  The `build_dir_name` parameter is not properly validated and it's then used to construct the `buildDir` that is read. The file/directory names under the `buildDir` will be returned. \n\n### Details\n\n- file: https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/admin.js#L2884-L2893\n\n```js\nrouter.get(\n  \"/build-mobile-app/result\",\n  isAdmin,\n  error_catcher(async (req, res) =\u003e {\n    const { build_dir_name } = req.query; // [1] source\n    const rootFolder = await File.rootFolder();\n    const buildDir = path.join(\n      rootFolder.location,\n      \"mobile_app\",\n      build_dir_name // [2]\n    );\n    const files = await Promise.all(\n      fs\n        .readdirSync(buildDir) // [3] sink\n        .map(async (outFile) =\u003e await File.from_file_on_disk(outFile, buildDir))\n    );\n    [...]\n  })\n);\n```\n\n### PoC\n\n- log into the application as an admin user\n- visit the following url: `http://localhost:3000/admin/build-mobile-app/result?build_dir_name=/../../../../../../../../`\n\n\n**NOTE**: it's possible to only see file and directory names but not to download their content.\n\n### Impact\n\nInformation disclosure\n\n### Recommended Mitigation\n\nResolve the `buildDir` and check if it starts with `${rootFolder.location}/mobile_app`.","modified":"2024-10-03T19:46:43Z","published":"2024-10-03T19:46:42Z","database_specific":{"severity":"MODERATE","github_reviewed":true,"github_reviewed_at":"2024-10-03T19:46:42Z","nvd_published_at":null,"cwe_ids":["CWE-548"]},"references":[{"type":"WEB","url":"https://github.com/saltcorn/saltcorn/security/advisories/GHSA-cfqx-f43m-vfh7"},{"type":"WEB","url":"https://github.com/saltcorn/saltcorn/commit/81adaf78430a9b59804894574d67d2a0c7bb3dc5"},{"type":"PACKAGE","url":"https://github.com/saltcorn/saltcorn"},{"type":"WEB","url":"https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/admin.js#L2884-L2893"}],"affected":[{"package":{"name":"@saltcorn/server","ecosystem":"npm","purl":"pkg:npm/%40saltcorn/server"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"1.0.0-beta.14"}]}],"database_specific":{"last_known_affected_version_range":"\u003c= 1.0.0-beta.13","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/10/GHSA-cfqx-f43m-vfh7/GHSA-cfqx-f43m-vfh7.json"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:H/I:N/A:N"},{"type":"CVSS_V4","score":"CVSS:4.0/AV:N/AC:L/AT:N/PR:H/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N/E:P"}]}