{"id":"GHSA-8mj7-wxmc-f424","summary":"Use after free in Neon external buffers","details":"Neon provides functionality for creating JavaScript `ArrayBuffer` (and the `Buffer` subtype) instances backed by bytes allocated outside of V8/Node. The [`JsArrayBuffer::external`](https://docs.rs/neon/0.10.0/neon/types/struct.JsArrayBuffer.html#method.external) and [`JsBuffer::external`](https://docs.rs/neon/0.10.0/neon/types/struct.JsBuffer.html#method.external) did not require `T: 'static` prior to Neon `0.10.1`. This allowed creating an externally backed buffer from types that may be freed while they are still referenced by a JavaScript `ArrayBuffer`.\n\nThe following example demonstrates use after free. It compiles on versions `\u003c0.10.1` and fails to compile afterward.\n\n```rust\npub fn soundness_hole(mut cx: FunctionContext) -\u003e JsResult\u003cJsArrayBuffer\u003e {\n    let mut data = vec![0u8, 1, 2, 3];\n    \n    // Creating an external from `&mut [u8]` instead of `Vec\u003cu8\u003e` since there is a blanket impl\n    // of `AsMut\u003cT\u003e for &mut T`\n    let buf = JsArrayBuffer::external(&mut cx, data.as_mut_slice());\n\n    // `buf` is still holding a reference to `data`!\n    drop(data);\n\n    Ok(buf)\n}\n```\n","aliases":["RUSTSEC-2022-0028"],"modified":"2023-11-08T04:17:25.410603Z","published":"2022-06-17T00:13:40Z","database_specific":{"github_reviewed_at":"2022-06-17T00:13:40Z","nvd_published_at":null,"cwe_ids":[],"severity":"HIGH","github_reviewed":true},"references":[{"type":"WEB","url":"https://github.com/neon-bindings/neon/issues/896"},{"type":"PACKAGE","url":"https://github.com/neon-bindings/neon"},{"type":"WEB","url":"https://rustsec.org/advisories/RUSTSEC-2022-0028.html"}],"affected":[{"package":{"name":"neon","ecosystem":"crates.io","purl":"pkg:cargo/neon"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0.8.0"},{"fixed":"0.10.1"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/06/GHSA-8mj7-wxmc-f424/GHSA-8mj7-wxmc-f424.json"}}],"schema_version":"1.9.0"}