{"id":"GHSA-3fp5-2xwh-fxm6","summary":"Evmos transaction execution not accounting for all state transition after interaction with precompiles","details":"### Context\n\n- [`stateObject`](https://github.com/evmos/evmos/blob/b196a522ba4951890b40992e9f97aa610f8b5f9c/x/evm/statedb/state_object.go#L53-L68): represents the state of an account and is used to store its updates during a state transition. This is accomplished using two in memory Storage variables: `originStorage` and `dirtyStorage`\n- [`StateDB`](https://github.com/evmos/evmos/blob/b196a522ba4951890b40992e9f97aa610f8b5f9c/x/evm/statedb/statedb.go#L33-L55): it is the general interface to retrieve accounts and holds a map of stateObjects.\n\n### Impact\n\nAn external contributor, @iczc, discovered a way to mint arbitrary tokens due to the possibility to have two different states not in sync during the execution of a transaction. The exploit is based on the fact that to sync the Cosmos SDK state and the EVM one, we rely on the `stateDB.Commit()` method. When we call this method, we iterate though all the `dirtyStorage` and, **if and only if** it is different than the `originStorage`, we [set the new state](https://github.com/evmos/evmos/blob/b196a522ba4951890b40992e9f97aa610f8b5f9c/x/evm/statedb/statedb.go#L460-L465). Setting the new state means we update the Cosmos SDK KVStore. \n\nBelow, are described the steps to perform the attack:\n\n- User send a tx to a smart contract (SC) that is calling a precompile. \n- The SC perform a state transition of its state from A to B.\n- The SC call the precompile.\n- The SC perform a state transition of its state from B to A (revert of the previous).\n- Once the transaction is executed, and the final **Commit** is performed, the state A will not be committed to the store because A is the same as `originStorage`. \n\nIf the tx is executed correctly, this is what happens at the store level:\n\n- Initial state A is loaded from the KVStore and the dirtyStorage is set to B.\n- Before running the precompile, the `dirtyStorage` is committed to the KVStore without changing the `originStorage`.\n- Now, since we have a `dirtyStorage`, it is updated to the previous value A without changing the `originStorage`.\n\nSince the tx executed correctly, the evm calls the commit to persist the dirtyStorage. However, since dirtyStorage is equal to originStorage, nothing will be changed.\n\nTo summarize, if a contract storage state that is the same before and after a transaction, but is changed during the transaction and can call an external contract after the change, it can be exploited to make the transaction similar to non-atomic. The vulnerability is **critical** since this could lead to drain of funds through creative SC interactions. \n\n### Severity\n\nBased on [ImmuneFi Severity Classification System](https://immunefisupport.zendesk.com/hc/en-us/articles/13332717597585-Severity-Classification-System) the severity was evaluated to `Critical` since the attack could have lead to direct loss of funds.\n\n### Patches\n\nThe issue has been patched in versions \u003e=V17.0.0. \n\n## For more information\nIf you have any questions or comments about this advisory:\n\nReach out to the Core Team in [Discord](https://discord.gg/evmos)\nOpen a discussion in [evmos/evmos](https://github.com/evmos/evmos/discussions)\nEmail us at [security@evmos.org](mailto:security@evmos.org) for security questions\n","aliases":["CVE-2024-32644","GO-2024-2715"],"modified":"2026-09-10T03:50:10.906001718Z","published":"2024-04-10T22:04:30Z","database_specific":{"nvd_published_at":"2024-04-19T15:15:50Z","cwe_ids":["CWE-662"],"severity":"CRITICAL","github_reviewed":true,"github_reviewed_at":"2024-04-10T22:04:30Z"},"references":[{"type":"WEB","url":"https://github.com/evmos/evmos/security/advisories/GHSA-3fp5-2xwh-fxm6"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2024-32644"},{"type":"WEB","url":"https://github.com/evmos/evmos/commit/08982b5ee726b97bc50eaf58d1914829648b6a5f"},{"type":"PACKAGE","url":"https://github.com/evmos/evmos"},{"type":"WEB","url":"https://github.com/evmos/evmos/blob/b196a522ba4951890b40992e9f97aa610f8b5f9c/x/evm/statedb/state_object.go#L53-L68"},{"type":"WEB","url":"https://github.com/evmos/evmos/blob/b196a522ba4951890b40992e9f97aa610f8b5f9c/x/evm/statedb/statedb.go#L33-L55"},{"type":"WEB","url":"https://github.com/evmos/evmos/blob/b196a522ba4951890b40992e9f97aa610f8b5f9c/x/evm/statedb/statedb.go#L460-L465"}],"affected":[{"package":{"name":"github.com/evmos/evmos/v16","ecosystem":"Go","purl":"pkg:golang/github.com/evmos/evmos/v16"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"17.0.0"}]}],"database_specific":{"last_known_affected_version_range":"\u003c= 16.0.4","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/evmos/evmos/v7","ecosystem":"Go","purl":"pkg:golang/github.com/evmos/evmos/v7"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"7.0.0"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/evmos/evmos/v6","ecosystem":"Go","purl":"pkg:golang/github.com/evmos/evmos/v6"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"6.0.4"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/evmos/evmos/v5","ecosystem":"Go","purl":"pkg:golang/github.com/evmos/evmos/v5"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"5.0.0"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/tharsis/evmos","ecosystem":"Go","purl":"pkg:golang/github.com/tharsis/evmos"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"1.1.3"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/tharsis/evmos/v2","ecosystem":"Go","purl":"pkg:golang/github.com/tharsis/evmos/v2"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"2.0.2"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/tharsis/evmos/v3","ecosystem":"Go","purl":"pkg:golang/github.com/tharsis/evmos/v3"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"3.0.3"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/tharsis/evmos/v4","ecosystem":"Go","purl":"pkg:golang/github.com/tharsis/evmos/v4"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"4.0.2"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}},{"package":{"name":"github.com/tharsis/evmos/v5","ecosystem":"Go","purl":"pkg:golang/github.com/tharsis/evmos/v5"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"last_affected":"5.0.1"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/04/GHSA-3fp5-2xwh-fxm6/GHSA-3fp5-2xwh-fxm6.json"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:H"}]}