{"id":"GHSA-39p2-8hq9-fwj6","summary":"GitProxy New Branch Approval Exploit","details":"### Summary\nAn attacker can exploit the way GitProxy handles new branch creation to bypass the approval of prior commits on the parent branch.\n\nBecause it can greatly affect system integrity, we classify this as a High impact vulnerability.\n\n### Details\nGitProxy checks for the `0000000000000000000000000000000000000000` hash to detect new branches. This is used to process the commit accordingly in both `getDiff.ts` and `parsePush.ts`. However, the logic can be exploited as follows:\n\n1. Make a commit in branch `a` (could be `main`)\n2. Make a new branch `b` from that commit\n3. Make a new commit in `b`, then approve it/get it approved\n4. Go back to `a`, and attempt to push this commit to the proxy\n\nThe unapproved commit from `a` will be pushed to the remote.\n\n### PoC\nTo reproduce this vulnerability:\n\n1. Clone the target repository and make an unapproved commit on a mainline branch (e.g. main):\n\n```bash\ngit checkout -b a origin/main\necho \"DEBUG=true\" \u003e config.env\ngit add config.env\ngit commit -m \"Sensitive debug config\"\ngit push proxy a\n```\n\n2. Without approving/getting the commit approved on branch `a`, create a new branch `b` based on it:\n\n```bash\ngit checkout -b b\necho \"feature x implemented\" \u003e feature.txt\ngit add feature.txt\ngit commit -m \"Feature implementation\"\ngit push proxy b\n```\n\n3. Approve/get approval for the push to branch `b`.\n\n4. Now attempt to push the original unapproved commit from branch `a`:\n\n```bash\ngit checkout a\ngit push proxy a\n```\n\nPrior to `1.19.2`, this results in unapproved commits from `a` getting pushed without any policy checks or explicit approval.\n\nFrom `1.19.2` onwards, this flow will allow pushing all commits to branch `b` (and explicit approval will be asked for the changes on `b` only). However, commits on branch `a` now require approval on push. If merging branch `b` into `a`, this also requires explicit approval of the (previously unapproved) commits originating from `a` to prevent loopholes.\n\n### Impact\nThe vulnerability impacts all users or organizations relying on GitProxy to enforce policy and prevent unapproved changes. It requires no elevated privileges beyond regular push access, and no extra user interaction. It does however, require a GitProxy administrator or designated user (`canUserApproveRejectPush`) to approve pushes to the child branch.","aliases":["CVE-2025-54585"],"modified":"2025-07-31T11:18:46Z","published":"2025-07-30T16:40:35Z","database_specific":{"severity":"HIGH","github_reviewed":true,"github_reviewed_at":"2025-07-30T16:40:35Z","nvd_published_at":"2025-07-30T21:15:26Z","cwe_ids":["CWE-285"]},"references":[{"type":"WEB","url":"https://github.com/finos/git-proxy/security/advisories/GHSA-39p2-8hq9-fwj6"},{"type":"ADVISORY","url":"https://nvd.nist.gov/vuln/detail/CVE-2025-54585"},{"type":"WEB","url":"https://github.com/finos/git-proxy/commit/a620a2f33c39c78e01783a274580bf822af3cc3a"},{"type":"WEB","url":"https://github.com/finos/git-proxy/commit/f99fe42082eab0970e4cd0acdc3421a527a7e531"},{"type":"PACKAGE","url":"https://github.com/finos/git-proxy"},{"type":"WEB","url":"https://github.com/finos/git-proxy/releases/tag/v1.19.2"}],"affected":[{"package":{"name":"@finos/git-proxy","ecosystem":"npm","purl":"pkg:npm/%40finos/git-proxy"},"ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"1.19.2"}]}],"database_specific":{"last_known_affected_version_range":"\u003c= 1.19.1","source":"https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2025/07/GHSA-39p2-8hq9-fwj6/GHSA-39p2-8hq9-fwj6.json"}}],"schema_version":"1.9.0","severity":[{"type":"CVSS_V4","score":"CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:P/VC:N/VI:H/VA:N/SC:N/SI:H/SA:N"}]}